Skip to content

make one(::Dual) return underlying Real type #664

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make one(::Dual) return underlying Real type #664

wants to merge 4 commits into from

Conversation

stevengj
Copy link
Contributor

@stevengj stevengj commented Sep 18, 2023 •
edited
Loading

Fixes #624

Also fixes #651 and closes #665, since it turns out that this change requires that fix too.

@stevengj stevengj mentioned this pull request Sep 18, 2023
Open
@stevengj
Copy link
Contributor Author

Closing based on discussion in JuliaPhysics/DynamicQuantities.jl#40

@ajwheeler
Copy link

@stevengj did you mean to close this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

construct_seeds for types where typeof(one(T)) !=T is broken one(::type(Dual))
2 participants
@stevengj @ajwheeler